Skip to content

Website: add documentation about fee transfers #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dw/update-links-caml-and-doc-tx-logic
Choose a base branch
from
Open

Website: add documentation about fee transfers #1585

wants to merge 2 commits into from

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 31, 2025 •
edited
Loading

No description provided.

@dannywillems
Add fee transfers documentation and update sidebar
44b5998 
Adds comprehensive fee transfer transaction documentation including:
- Overview and transaction structure
- Single vs. double transfer examples
- Token constraints and validation
- Account creation handling
- Test coverage references

Updates sidebar to include fee-transfers.md under Transaction types.

Changes ported from mina-rust PR #1553.
@dannywillems
CHANGELOG: add entry for patch 1584
aaa9194
@dannywillems dannywillems force-pushed the dw/update-links-caml-and-doc-tx-logic branch from 44b5998 to bc5b5d8 Compare October 31, 2025 15:18
@dannywillems dannywillems changed the title CHANGELOG: add entry for patch 1584 Website: add documentation about fee transfers Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

⚠️ Code Reference Verification Failed

The documentation contains code references that do not match the current state of the codebase on the develop branch.

Issues Found

  • website/docs/developers/transactions/coinbase.md:144 - Code reference to ledger/src/scan_state/transaction_logic/transaction_partially_applied.rs#L559-L561 differs from GitHub (develop branch). The referenced code may have been modified locally but not yet merged to develop.

Action Required

The code referenced in the documentation must be merged to develop before documentation can be added/modified.

Please follow this workflow:

  1. Merge the code changes to develop first (this PR or a separate code PR)
  2. Create a follow-up PR with the documentation updates that reference the merged code
  3. The verification will pass once the code is available on develop

See the documentation guidelines for more information about the two-PR workflow.

richardpringle
richardpringle requested changes Oct 31, 2025
View reviewed changes
Copy link

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permalinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardpringle richardpringle richardpringle requested changes

Assignees

No one assigned

Labels

None yet

Projects

Rust node
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannywillems @richardpringle